Repository navigation
Conversation
When native code invokes a registered callback from the event loop, no callback scope is active. A nextTick or microtask queued by the callback only ran when an unrelated Node.js callback fired, or at beforeExit. Open an InternalCallbackScope in InvokeCallback when no scope is active, so the queues are drained when the callback returns. Callbacks invoked synchronously during a call into native code already run inside the caller's scope and are left unchanged. Signed-off-by: Trivikram Kamat <16024985+trivikr@users.noreply.github.com> Assisted-by: claude:opus-5.5
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
trivikr
added
ffi
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66918 +/- ##
=======================================
Coverage 90.58% 90.58%
=======================================
Files 797 797
Lines 278494 278499 +5
Branches 53541 53539 -2
=======================================
+ Hits 252270 252288 +18
- Misses 16547 16558 +11
+ Partials 9677 9653 -24
🚀 New features to boost your workflow:
|
ShogunPanda
approved these changes
Oct 22, 2026
github-actions
Bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
trivikr
added
author ready
github-actions
Bot
removed
the
resume-ci
Collaborator
daeyeon
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #66917
When native code invokes a registered callback from the event loop, no callback scope is active. A nextTick or microtask queued by the callback only ran when an unrelated Node.js callback fired, or at beforeExit.
Open an InternalCallbackScope in InvokeCallback when no scope is active, so the queues are drained when the callback returns. Callbacks invoked synchronously during a call into native code already run inside the caller's scope and are left unchanged.
Assisted-by: claude:opus-5.5