Repository navigation
cmd/rofl: Add support for the proxy_protocol port annotation - #760
Merged
uniyalabhishek merged 1 commit intoNov 20, 2026
Merged
Conversation
✅ Deploy Preview for oasisprotocol-cli canceled.
|
uniyalabhishek
marked this pull request as ready for review
November 19, 2026 11:48
uniyalabhishek
requested review from
kostko,
martintomazic and
matevz
and removed request for
martintomazic
November 19, 2026 11:51
matevz
reviewed
Nov 19, 2026
matevz
left a comment
Member
There was a problem hiding this comment.
Is there a difference between v1 and v2 from the developer's point of view? IMO we can just make a switch and silently use v2 everywhere with the new scheduler/containers version.
Contributor
Author
yes. v1 is text and v2 is binary, and the app's server must read the format we send. we also cannot turn it on everywhere, because an app that does not expect the header breaks. so it is opt-in per port, and the value says which format. |
kostko
reviewed
Nov 20, 2026
uniyalabhishek
force-pushed
the
uniyalabhishek/feature/rofl-proxy-protocol
branch
from
November 20, 2026 09:10
0302555 to
1b95dcf
Compare
kostko
approved these changes
Nov 20, 2026
uniyalabhishek
deleted the
uniyalabhishek/feature/rofl-proxy-protocol
branch
November 20, 2026 09:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements CLI support for oasisprotocol/oasis-sdk#2516 (companion to oasisprotocol/oasis-sdk#2616).
Validates
net.oasis.proxy.ports.<published_port>.proxy_protocolincompose.yaml(allowing onlyv2) and setsnet.oasis.proxy.proxy_protocoltov2in deployment metadata duringoasis rofl deploywhen any exposed TCP port enables it.Release after rofl-scheduler and rofl-containers together with bumping the rofl-containers artifact, since older guest images cannot decode the new
proxy_protocollabel field when enabled.