Repository navigation
feat(herdr): name this computer in the agents panel - #438
Merged
Merged
Conversation
- Show the host on this computer's agents too, not only remote ones. - The user often works on the desktop from the laptop, so an unnamed row is ambiguous; always naming the host removes the guess. - Read the hostname with uname -n, as odsod-spaces does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The agents panel names the host on every agent, including this computer's.
Before, only agents on other machines showed one. The user often works on the
desktop from the laptop, so an unnamed row was ambiguous.
herdr/app/patches/agents.patchreads the hostname withuname -n, asodsod-spacesdoes, and uses it where an agent's address has no<machine>/prefix.Tested on the desktop: the patch rebuilds
odsod-agents,herdr-app checkpasses, and the panel shows
odsod-desktopandodsod-x1-carbonon the twomachine agents.
mise run checkpasses.