Repository navigation
examples: document Python requirements for structured outputs - #805
Open
cloudgpuapp wants to merge 1 commit into
Open
cloudgpuapp wants to merge 1 commit into
cloudgpuapp wants to merge 1 commit into
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Document the minimum Python versions of the three structured-output examples. The text examples evaluate
list[T]at class definition time, which requires Python 3.9. The image example also evaluatesstr | None, which requires Python 3.10. Both failures happen before a request is sent.This keeps the modern annotations discussed in #373 and makes the requirements visible where the examples are listed.
Verification
Ran all three unchanged scripts with mocked HTTP responses. Python 3.8.20 failed before requesting a response in all three. Python 3.9.6 ran both text examples but failed to load the image example. Python 3.10.22 ran all three. The successful runs checked the generated JSON schema and parsed the mocked responses. No Ollama server or model was started.