Repository navigation
Report a directory missing in the reference, instead of a traceback - #20
Merged
Merged
Conversation
collect_tasks made each path relative to the root of tree A. A directory that only tree B has is not below that root, so relative_to raised a ValueError, and the comparison stopped with a traceback. The walk now carries the relative path itself, which is the same for both trees. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FW6WZZjzbcNvNppdDrFxKB
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code
What changes
collect_tasksmade each path relative to the root of tree A. A directory that only tree B has is not below that root. Sorelative_toraised aValueError, andcompare-htmlstopped with a traceback instead of the report "missing in reference (A)".The walk now carries the relative path itself (
rel), which is the same for both trees. Therootparameter is gone; only the recursion used it.OpenDocument.core hits this when a PR adds new test fixtures, for example opendocument-app/OpenDocument.core#1293:
Checks
tests/test_collect_tasks.pyhas a file and a directory on each side only, and a pair in a shared directory. It fails with theValueErrorabove onmainand passes with this change.black src testschanges nothing.https://claude.ai/code/session_01FW6WZZjzbcNvNppdDrFxKB