[adityahabib]

Fix #360

save_large_file now accepts a headers argument and sends the
Wikimedia-compliant default User-Agent for upload.wikimedia.org when none
is given. An explicit User-Agent (from headers or user_agent) is kept.
This follows the approach #353 used for stream_file.

Changes:

• download.py: new headers parameter, merged into the request headers
• tests: 5 new tests (default UA, custom UA kept, extra headers merged,
  caller's dict not modified, other hosts untouched)
• CHANGELOG entry

Tested locally: pytest tests/download/test_download.py, all passing.

Thank you

[benoit74]

@adityahabib I'm sorry but I will close this in favor of #362 ; I know you've been assigned the issue and @pawank925 should not have pushed a PR on something assigned to someone else but:

• you never responded to my ping in save_large_file should use default user-agent and accept arbitrary headers #360
• this PR is worse than Send default User-Agent and accept headers in save_large_file #362 (passed user-agent does not always wins over passed headers, QA is failing, ...) and was obviously 100% AI generated (I don't mind you generate code with AI, but this should not prevent you from engaging in your work and it even give less excuses for not having full green PR on first try)
• I want to quickly merge a solution, others are waiting for it (Impossible to ZIM files from upload.wikimedia.org nautilus#101)

I'm a bit sorry about that, but I hope you will understand

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (b5ad688) to head (b986c95).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##              main      #363   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           42        42           
  Lines         2852      2859    +7     
  Branches       428       430    +2     
=========================================
+ Hits          2852      2859    +7     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.