Repository navigation
Add slot column to sleds tab on inventory page - #3416
Open
charliepark wants to merge 2 commits into
Open
charliepark wants to merge 2 commits into
charliepark wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
|
I would drop refresh. The only other pages that have it all have polling because they have a concept of transitional states: instances, support bundles, update. |
Collaborator
|
How about putting the slot first since it's usually the thing people index on? It looks a little lopsided, I almost want to center or right align it but I don't think we do that. @benjaminleonard ? 
|
Contributor
|
I prefer slot first. Leading 0 and tabular nums would do a similar thing for alignment, but last time I tried to enable tabular nums it didn't work. I'm convinced a new version of the font does have it, going to investigate. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have some more involved designs in the works, so might decide to close this PR without merging, but as an MVP, this gets the sled's slot onto the inventory page, and then also in the data table on the sled's view page.
I also added a refresh button to go in the header, so users can manually refresh the data on the page (e.g. a sled has just been installed and they want to verify that — after everything registers in the system — that it's accurately reflected on the list) though that isn't essential.
Closes #3327