Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Avoid inserting a second
<?phpopener when a line comment in an alternative-syntaxifis immediately followed by a PHP close tag and inline HTML. Treat the commented inline node as nested in the existing short-formifblock so the printer keeps the current PHP context.Evidence
The reproducer from #2494 formatted as
<?php if (true):<?php, which introduces a syntax error. The newtests/inline/mixed-2494.phpfixture now formats without the extra opener.Checks run:
node node_modules/jest/bin/jest.js --runInBand— 101 suites, 597 tests, and 581 snapshots passed.node --check src/printer.mjs— passed.git diff --check— passed.Merge Danger
Door: two-way
Blast Radius: localized
Fixes #2494