Repository navigation
fix(mcp): coupon tools return the coupon, not its column list (1.9.3) - #97
Merged
Merged
Conversation
db.sql binds every ${} as a parameter, so `SELECT ${couponFields}` selected
the column list as one string literal. search_coupons, top_coupons,
store_coupons and get_coupon returned `?column?: "c.id, c.code, ..."` plus
the store name, and no code, title or id. The columns are now written into
each query, and test/mcp-tools.test.mjs runs the four tools against the
real migration.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ThreatCrush Security Scan38 finding(s) MEDIUM: 32 | LOW: 6
Snippets are redacted; ThreatCrush never prints matched credential material. |
…ons keep their own DB Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MCP coupon tools returned no coupons.
db.sqlbinds every${}as a parameter, soSELECT ${couponFields}selected the column list as a single string literal. Live,top_couponscame back as:{ "?column?": "c.id, c.code, c.title, ...", "store_name": "Profullstack", "store_slug": "profullstack" }This affected search_coupons, top_coupons, store_coupons and get_coupon: no id, code or title.
test/mcp-tools.test.mjsruns the four tools against the real migration in a libSQL file. It fails on master and passes here. Full suite: 84 pass.🤖 Generated with Claude Code