Repository navigation
fix(alerts): speak links as domain + path, no http:// on calls - #135
Merged
Merged
Conversation
Alert calls read links aloud scheme and all. alertSpeech now runs spokenLinks first: https://threatcrush.com/incidents/42?t=x becomes threatcrush.com/incidents/42. Query strings, fragments and a trailing slash are dropped. Texts keep the full link. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ThreatCrush Security Scan14 finding(s) HIGH/CRITICAL: 2 | MEDIUM: 4 | LOW: 8
Snippets are redacted; ThreatCrush never prints matched credential material. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Anthony: "for threatcrush when you call me can you not say the http:// in links just start with domain name ... and path".
spokenLinks()insrc/lib/alerts/call.ts:https://threatcrush.com/incidents/42?token=x#ais spoken asthreatcrush.com/incidents/42; query/fragment and trailing slash dropped, sentence punctuation kept.alertSpeech(every alert call, ThreatCrush pages included). SMS text is unchanged so links stay tappable.bunx vitest run src/lib/alerts23/23.🤖 Generated with Claude Code