Repository navigation
Fix pycurl file:// fetches and origin-header CRLF injection - #36
Merged
Merged
Conversation
Block file:// and other non-HTTP schemes in pycurl_proxy.request(), pin libcurl protocols to HTTP(S), and validate origin headers and methods so CR/LF cannot smuggle extra request lines. Co-authored-by: ProxyMesh AI <proxymeshai@users.noreply.github.com>
Collaborator
|
bugbot review |
Contributor
Author
|
Skipping Bugbot: Bugbot is disabled for this repository. Visit the Bugbot dashboard to update your settings. |
Contributor
Author
|
Review: no issues found. Checked the high-level pycurl changes for non-HTTP scheme bypasses (including No code changes. PR left as a draft. |
proxymeshai
marked this pull request as ready for review
November 1, 2026 21:08
proxymesh
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restricts the high-level pycurl helper so it cannot fetch non-HTTP URLs or smuggle extra request lines.
python_proxy_headers.pycurl_proxy.request()/get()previously passed caller URLs and origin headers straight to libcurl. That allowedfile://local-file reads (even when a proxy was set) and CR/LF in origin headers or the HTTP method.Changes
http/httpsURLs and control characters invalidate_http_url()PROTOCOLS/REDIR_PROTOCOLSto HTTP(S)validate_headers()and methods withvalidate_http_method()beforesetoptfile://,dict://, origin-header CRLF, and method CRLFLow-level
set_proxy_headers()/ raw pycurl usage is unchanged.