Bug report

Bug description:

With the "zip" format, shutil.make_archive() adds the archive it is writing to itself when the output path is inside the directory being archived. _make_zipfile() walks the tree and writes every regular file it finds, including the partly written archive (TarFile.add() already skips the archive for the tar formats).

import os, shutil, zipfile
os.mkdir('d'); os.chdir('d')
open('f', 'w').close()
shutil.make_archive('test', 'zip')
print(zipfile.ZipFile('test.zip').namelist())  # ['test.zip', 'f']

The archive member is a truncated copy of the output. If a symlink in the tree points at the archive and is reached after some data has been flushed, the archive keeps growing until the disk is full or a file size limit is hit (OSError: [Errno 27] File too large).

gh-104527 fixed the same problem in zipapp.

CPython versions tested on:

CPython main branch

Operating systems tested on:

Linux

Linked PRs

• gh-161112: Fix shutil.make_archive() adding a zip archive to itself #161113
• [3.14] gh-161112: Fix shutil.make_archive() adding a zip archive to itself (GH-161113) #161139
• [3.15] gh-161112: Fix shutil.make_archive() adding a zip archive to itself (GH-161113) #161140