Repository navigation
gh-161106: Use repeat counts in plistlib binary writer struct formats - #161107
Merged
Merged
Conversation
…ormats Compiled struct formats with one code per item stay in the struct module's cache and take about 33 bytes per item. Use the repeat-count form the reader already uses; the output is unchanged.
gpshead
added
needs backport to 3.14
gpshead
added
needs backport to 3.14
gpshead
marked this pull request as ready for review
November 1, 2026 18:23
gpshead
enabled auto-merge (squash)
November 1, 2026 18:23
|
Thanks @gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15. |
|
GH-161137 is a backport of this pull request to the 3.14 branch. |
|
GH-161138 is a backport of this pull request to the 3.15 branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use repeat-count
structformats (f'>{n}{code}') for the array and dict reference lists and the offset table in the binary plist writer, matching what the reader has done since gh-86269. A compiled'>' + code * nformat takes about 33 bytes per item and stays in thestructmodule's format cache afterdumps()returns; a repeat-count format is constant size. The packed bytes are identical.Fixes #161106
ANT-2026-1L9EBYNF
plistlibbinary writer leaves large formats in thestructcache #161106