Repository navigation
gh-131178: Fix test_cli_retrieve_file when stdout is StringIO in test_ftplib - #161135
Merged
Merged
Conversation
Mock sys.stdout in CommandLineTest.test_cli_retrieve_file so that accessing sys.stdout.buffer does not fail when regrtest or other test runners wrap sys.stdout in an io.StringIO object.
bedevere-app
Bot
added
awaiting review
type-feature
7 of 9 tasks
orsenthil
added
skip news
and removed
type-feature
orsenthil
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #161080,
test_cli_retrieve_filewas added toLib/test/test_ftplib.py. Inftplib.test(), file retrieval callsftp.retrbinary('RETR ' + file, sys.stdout.buffer.write, 1024)andsys.stdout.buffer.flush().When tests run under regrtest on buildbots,
sys.stdoutis wrapped in anio.StringIOinstance which lacks a.bufferattribute, causingAttributeError: '_io.StringIO' object has no attribute 'buffer'.This patch mocks
sys.stdoutinCommandLineTest.test_cli_retrieve_fileto prevent the error and assert the callback and flush calls.Follow-up to #161080.