Repository navigation
Conversation
Documentation build overview
50 files changed ·
|
sirosen
left a comment
There was a problem hiding this comment.
I'm open to alternative opinions, but I think we can improve the text by striking a little bit, and no additional edits.
|
Thanks @sirosen, agreed on both points. I dropped the last two sentences. I have made the requested changes; please review again. |
|
Thanks for making the requested changes! : please review the changes made to this pull request. |
sirosen
left a comment
There was a problem hiding this comment.
Awesome! I think this is a good addition.
It occurs to me that "virtual subclass" could be used to describe any situation with ABC-like specialized subclass checks. But I think it's best as stated: narrow and easy to understand.
@nedbat, since you filed the original issue, I'm curious what you think.
The "abstract base class" glossary entry mentions virtual subclasses but the
term had no entry of its own. This adds a short
virtual subclassentry(between "virtual machine" and "walrus operator") that explains:
issubclass()andisinstance()treat a virtual subclass as a subclass of anABC, even though it does not inherit from the ABC;
ABCMeta.register(); an ABC can also recognizeclasses without registration via
__subclasshook__();The existing mention in "abstract base class" now links to the new term. No
other text is changed.
Docs-only change, so this needs the
skip newslabel.AI disclosure: prepared with the help of Claude Code; I reviewed the change and the test results.