Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Lib/email/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -394,6 +394,8 @@ def encode_rfc2231(s, charset=None, language=None):
s = urllib.parse.quote(s, safe='', encoding=charset or 'ascii')
if charset is None and language is None:
return s
if charset is None:
charset = ''
if language is None:
language = ''
return "%s'%s'%s" % (charset, language, s)
Expand Down
10 changes: 10 additions & 0 deletions Lib/test/test_email/test_email.py
Original file line number Diff line number Diff line change
Expand Up @@ -5926,6 +5926,16 @@ def test_rfc2231_unencoded_then_encoded_segments(self):
eq(language, 'en-us')
eq(s, 'My Document For You')

def test_rfc2231_encode_language_without_charset(self):
eq = self.assertEqual
eq(utils.encode_rfc2231('abc', language='en'), "'en'abc")
msg = Message()
msg.add_header('Content-Disposition', 'attachment',
filename=(None, 'en', 'report.txt'))
eq(msg['Content-Disposition'],
"attachment; filename*='en'report.txt")
eq(msg.get_filename(), 'report.txt')

def test_should_not_hang_on_invalid_ew_messages(self):
messages = ["""From: user@host.com
To: user@host.com
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Fix :func:`email.utils.encode_rfc2231` writing the literal string ``None``
as the charset when only *language* is given. The charset field is now left
blank, as permitted by :rfc:`2231`.
Loading