Repository navigation
gh-161335: Collapse runs of adjacent LITERAL opcodes into one _sre dispatch - #161332
Open
MercylinPreethi wants to merge 2 commits into
Open
MercylinPreethi wants to merge 2 commits into
MercylinPreethi wants to merge 2 commits into
Conversation
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Collapse runs of adjacent LITERAL opcodes into one
_sredispatch.In
SRE(match),SRE_OP_LITERALandSRE_OP_LITERAL_IGNOREeach matched one character and then went back to the computed-goto dispatch. This change loops while the next opcode is the same literal opcode, so a run of N literal characters costs one dispatch instead of N.Matching behavior is unchanged. The loop reads the next opcode right after each literal, which the old code did not do. That read stays in bounds because every compiled SRE pattern ends with
SUCCESSorFAILURE.Files:
Modules/_sre/sre_lib.hWhat we gain
Each literal character in a pattern is one opcode, and before this change each one paid a full dispatch. Patterns with long literal runs (
"Content-Length: ",(\d+) bytes received,foo|bar|baz) now match those runs in a tight loop. Patterns made of classes and repeats (\w+,.*?) are unaffected.Measured
pyperformance regex benchmarks, before vs after, compared with
pyperf compare_to:regex_effbot(+3.5%) andregex_dna(+2.2%), but 1.2% slower onregex_v8.regex_v8uses many short patterns with few literal runs, so the extra opcode read in the new loop isn't paid back there on this CPU.Test plan
test_repasses on latest main with the patch.regex_v8,regex_effbot,regex_dnaon all three machines (table above).