Repository navigation
[3.15] gh-75929: Fix configure function checks under -Wall -Werror (GH-161343) - #161371
Merged
Merged
Conversation
…ror (pythonGH-161343) Use `(void)$1` in `PY_CHECK_FUNC` instead of declaring an unused variable. The unused-variable warning caused configure to report declared functions such as `fchdir` as missing. (cherry picked from commit 341f80e) Co-authored-by: Vasiliy Kiryanov <vasiliy.kiryanov@gmail.com>
vasiliyk
requested review from
AA-Turner,
corona10,
emmatyping and
erlend-aasland
as code owners
November 5, 2026 00:07
This was referenced Nov 5, 2026
vstinner
enabled auto-merge (squash)
November 5, 2026 00:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I see on 3.15
PY_CHECK_CURSES_FUNCstill uses the oldvoid *x=$1probe, so the 13 curses function checks have the same -Werror problem.Main fixed that macro separately in gh-158078 (as a side effect), which was not backported.