Skip to content

[3.14] gh-161185: Fix test_cext: replace PyType_FromSlots() with PyType_FromSpec() #161373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 1 commit into from
Nov 5, 2026
+13 −7
Merged

[3.14] gh-161185: Fix test_cext: replace PyType_FromSlots() with PyType_FromSpec() #161373

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions Lib/test/test_cext/extension.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,26 +172,32 @@ xsetref_strict_aliasing(PyTypeObject **a, PyTypeObject **b,
Py_XSETREF(*b, second);
}

static PyType_Slot empty_type_slots[] = {
{0, 0},
};

static PyType_Spec setref_type_spec = {
STR(MODULE_NAME) ".setref_type", // .name
0, // .basicsize
0, // .itemsize
Py_TPFLAGS_DEFAULT, // .flags
empty_type_slots, // .slots
};

// gh-161185: Test that Py_SETREF(), Py_XSETREF() and Py_CLEAR() macros
// have no strict aliasing issue
static PyObject *
test_setref_strict_aliasing(PyObject *Py_UNUSED(module), PyObject *Py_UNUSED(args))
{
PySlot slots[] = {
PySlot_PTR_STATIC(Py_tp_name, STR(MODULE_NAME) ".setref_type"),
PySlot_PTR_STATIC(Py_tp_flags, Py_TPFLAGS_DEFAULT),
PySlot_END
};
PyObject *first, *second;
Py_ssize_t first_refcnt, second_refcnt;
PyTypeObject *slot = NULL;

first = PyType_FromSlots(slots);
first = PyType_FromSpec(&setref_type_spec);
if (first == NULL) {
return NULL;
}
second = PyType_FromSlots(slots);
second = PyType_FromSpec(&setref_type_spec);
if (second == NULL) {
Py_DECREF(first);
return NULL;
Expand Down
Loading