Skip to content

gh-161389: Fix crash when passing invalid flags and traps to decimal.Context #161393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sobolevn merged 3 commits into from
Nov 5, 2026
Merged

gh-161389: Fix crash when passing invalid flags and traps to decimal.Context #161393

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
28f5e80
gh-161389: Fix crash when passing invalid `flags` and `traps` to `dec…
sobolevn Nov 5, 2026
39ddbb0
Fix CI
sobolevn Nov 5, 2026
4aaf4d4
Fix CI
sobolevn Nov 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions Lib/test/test_decimal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3763,6 +3763,20 @@ def test_to_integral_value(self):
self.assertRaises(TypeError, c.to_integral_value, '10')
self.assertRaises(TypeError, c.to_integral_value, 10, 'x')

def test_crashing_signal_dict_traps(self):
# gh-161389
Context = self.decimal.Context
SignalDict = type(Context().traps)
with self.assertRaisesRegex((KeyError, ValueError), "signal dict"):
Context(traps=SignalDict())

def test_crashing_signal_dict_flags(self):
# gh-161389
Context = self.decimal.Context
SignalDict = type(Context().flags)
with self.assertRaisesRegex((KeyError, ValueError), "signal dict"):
Context(flags=SignalDict())

@requires_cdecimal
class CContextAPItests(ContextAPItests, unittest.TestCase):
decimal = C
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Library/2026-11-05-11-56-50.gh-issue-161389.EIl2E6.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Fixes a crash in :class:`decimal.Context` when passing invalid signaling
dicts as *flags* and *traps*.
6 changes: 6 additions & 0 deletions Modules/_decimal/_decimal.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1162,6 +1162,9 @@ context_settraps_dict(PyObject *self, PyObject *value)

decimal_state *state = get_module_state_from_ctx(self);
if (PyDecSignalDict_Check(state, value)) {
if (SdFlagAddr(value) == NULL) {
return value_error_int(INVALID_SIGNALDICT_ERROR_MSG);
}
flags = SdFlags(value);
}
else {
Expand Down Expand Up @@ -1228,6 +1231,9 @@ context_setstatus_dict(PyObject *self, PyObject *value)

decimal_state *state = get_module_state_from_ctx(self);
if (PyDecSignalDict_Check(state, value)) {
if (SdFlagAddr(value) == NULL) {
return value_error_int(INVALID_SIGNALDICT_ERROR_MSG);
}
flags = SdFlags(value);
}
else {
Expand Down
Loading