Repository navigation
Conversation
|
All commit authors signed the Contributor License Agreement. |
Member
|
The OP said they would be happy to work on a PR. |
picnixz
added
the
AI-guidelines-not-met
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes gh-161384.
IPv6Network('fe80::%eth0/64').explodedraisedAddressValueErrorbecause_explode_shorthand_ip_string()built the network text fromstr(self.network_address), which includes the%scopesuffix, and then passed it to_ip_int_from_string().Format the network address from its integer value instead, and append the scope ID before the prefix. For networks the scope lives on
network_address, so it is read from there; addresses and interfaces keep usingself._scope_id. Non-scoped networks and IPv4 are unchanged.Tests:
IpaddrUnitTest.testExplodeShortHandIpStrnow covers the network case. Built current main (5aa2f705) on aarch64 (GH200, GCC 13.3): the test passes with the patch and fails on unpatched main withAddressValueError.