Repository navigation
gh-161354: Fix test_ast.test_nodes_have_inline_values() - #161406
Merged
Merged
Conversation
Run the test in a subprocess to make it more deterministic.
Member
Author
|
@lysnikolaou @pablogsal: Would you mind to review my fix? |
Member
|
I know I added that test but I'm now wondering whether we actually want that test since it tests an internal implementation detail. If yes, then this LGTM. |
Member
Author
IMO the test is worth it. It checks that the implementation works as expected. Testing |
Eclips4
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run the test in a subprocess to make it more deterministic.