Repository navigation
gh-161471: Fix crash when subscripting a ctypes pointer without _type_ - #161421
Open
PavlNekrasov wants to merge 1 commit into
Open
PavlNekrasov wants to merge 1 commit into
PavlNekrasov wants to merge 1 commit into
Conversation
Check proto and the PyStgInfo_FromType() result instead of relying on assert() in Pointer_item_impl(), Pointer_ass_item_impl() and Pointer_subscript().
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Member
|
Pleae create an issue. |
Member
|
The question is also: why are you subclassing ctypes._Pointer? |
sobolevn
changed the title
_type__type_
Author
solely to reproduce the static-analysis finding |
Member
|
My question was: why do you believe the finding is correct? is this a documented behavior? are there other possibilities for messing with ctypes liks that? I want to know if @ZeroIntensity considers this an issue in the first place. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed #161471
_type_#161471