Skip to content

[reportlab] Update to 5.1.0 - #16311

Open
mxr wants to merge 7 commits into
python:mainfrom
mxr:patch-1
Open

mxr wants to merge 7 commits into
python:mainfrom
mxr:patch-1

Conversation

@mxr

@mxr mxr commented Aug 28, 2026 •

Copy link
Copy Markdown
Contributor

Updates stubs to reportlab 5.1.0, which also fixes the duplicate get_rl_tempdir entry in rltempfile.__all__. Also removes the stale lib/extformat.pyi, which upstream dropped in 5.0.0.

Release: https://pypi.org/pypi/reportlab/5.1.0
Homepage: https://www.reportlab.com/
Repository: https://github.com/MrBitBucket/reportlab-mirror
Changelog: https://github.com/MrBitBucket/reportlab-mirror/blob/master/CHANGES.md

Agent: Claude Code

I think this was a copy paste error but let me know
@github-actions

This comment has been minimized.

@AlexWaygood

Copy link
Copy Markdown
Member

this is causing CI to fail -- does it actually exist in __all__ in the runtime package?

@donbarbos

Copy link
Copy Markdown
Contributor

This is indeed a problem, but it is present in the library itself, both in 4.3.1 version (the last version supported by typeshed) and in the source code of the latest version. As I understand it, in situations like this, the usual approach is to follow the actual runtime behavior and keep the stubs consistent with it.

I suggest reporting the issue to the reportlab development team:

Please do not use this for issue reporting etc; use the mail list at
https://pairlist2.pair.net/mailman/listinfo/reportlab-users

But this address didn't open for me, so I found this mirror on Google Groups: https://groups.google.com/g/reportlab-users

@mxr

mxr commented Aug 28, 2026

Copy link
Copy Markdown
Contributor Author

Nice find. Reported in the mailing list.

@AlexWaygood AlexWaygood added the status: deferred Issue or PR deferred until some precondition is fixed label Aug 28, 2026
@srittau
srittau marked this pull request as draft August 29, 2026 12:47
@mxr

mxr commented Sep 1, 2026

Copy link
Copy Markdown
Contributor Author

Robin from reportlab emailed back and said "[...] thanks for the contribution. It will be in next release"

@AlexWaygood

Copy link
Copy Markdown
Member

We'll have to wait until that release is out before merging this, unfortunately — the CI here will continue to fail in the meantime

@mxr

mxr commented Sep 1, 2026

Copy link
Copy Markdown
Contributor Author

Makes sense

@donbarbos

Copy link
Copy Markdown
Contributor

If we want to keep the CI passing, I think this change should be included together with the version field (in METADATA.toml) update and all the other changes related to the version bump in the "update" PR (rather than in this separate PR).

@mxr

mxr commented Sep 1, 2026

Copy link
Copy Markdown
Contributor Author

Yes was thinking the same thing. I'll revisit this once the new release ships

@mxr

mxr commented Sep 21, 2026

Copy link
Copy Markdown
Contributor Author

Version 5.0.2 is out today so I will look into updating mypy stubs this week to close this out

@mxr

mxr commented Sep 28, 2026

Copy link
Copy Markdown
Contributor Author

The source is updated but the new version isn't on pypi yet

@mxr mxr changed the title Fix missing get_rl_tempfile in __all__ export [reportlab] Update to 5.1.0 Oct 31, 2026
@mxr
mxr marked this pull request as ready for review October 31, 2026 03:26
@mxr

mxr commented Oct 31, 2026

Copy link
Copy Markdown
Contributor Author

Looks like they went straight to 5.1.0 on pypi so I reworked my PR based on that. This supersedes #16384

@github-actions

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: deferred Issue or PR deferred until some precondition is fixed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants