Repository navigation
docker - remove dependency on types-requests because requests ships types - #16498
Open
MaicoTimmerman wants to merge 1 commit into
Open
MaicoTimmerman wants to merge 1 commit into
MaicoTimmerman wants to merge 1 commit into
Conversation
This comment has been minimized.
This comment has been minimized.
…ypes' Requests 2.34 ships inline type information, so depend on it directly instead of types-requests: - types-requests -> requests>=2.34.0: Requests now ships its own type information, so the separate stub package is redundant. As per python#15813 I've added the lower bound. - `Sequence[str]` -> `list[str]`: `APIClient` inherits `Session.__attrs__`, which Requests declares as `list[str]`. An overriding mutable attribute must keep the same type. - `ConnectionPool` -> `HTTPConnectionPool`: Requests declares `HTTPAdapter.get_connection_with_tls_context()` as returning `HTTPConnectionPool`. Docker’s override cannot use the broader `ConnectionPool` return type. Co-Authored-By: Factory Droid (GPT-5.6 Sol)
MaicoTimmerman
force-pushed
the
docker-types-dependency
branch
from
October 30, 2026 19:30
b6f689e to
018dadc
Compare
Contributor
Author
|
Hi @srittau, would it be possible to land this MR? It would unblock using the shipped types from |
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requests 2.34 ships inline type information, so depend on it directly instead of types-requests:
types-requests -> requests>=2.34.0: Requests now ships its own type information, so the separate stub package is redundant. As per
requests-oauthlib- remove dependency ontypes-requestsbecauserequestsnow comes with its own type annotations #15813 I've added the lower bound.Sequence[str]->list[str]:APIClientinheritsSession.__attrs__, which Requests declares aslist[str]. An overriding mutable attribute must keep the same type.ConnectionPool->HTTPConnectionPool: Requests declaresHTTPAdapter.get_connection_with_tls_context()as returningHTTPConnectionPool. Docker’s override cannot use the broaderConnectionPoolreturn type.Co-Authored-By: Factory Droid (GPT-5.6 Sol)