Repository navigation
hvac: add types for hvac.api.secrets_engines.consul - #16501
Open
MaicoTimmerman wants to merge 1 commit into
Open
MaicoTimmerman wants to merge 1 commit into
MaicoTimmerman wants to merge 1 commit into
Conversation
This comment has been minimized.
This comment has been minimized.
Types generated from the provided docstring on the class. The adapter on VaultApiBase already carries its response type, but VaultApiBase currently erases it with Adapter[Any]. We introduce a local generic without affecting the wider hvac API. - RawAdapter methods return Response. - JSONAdapter methods return Response | dict[Any, Any]. - Unparameterized Consul defaults to the standard JSON adapter union. Co-Authored-By: Factory Droid (GPT-5.6 Sol)
MaicoTimmerman
force-pushed
the
hvac-secret-engine-consul
branch
from
October 30, 2026 19:30
b94f6fa to
ff8533e
Compare
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types generated from the provided docstring on the class.
The adapter on VaultApiBase already carries its response type, but VaultApiBase currently erases it with Adapter[Any]. We introduce a local generic without affecting the wider hvac API. This can later on be expanded on to the different secret engines.
Co-Authored-By: Factory Droid (GPT-5.6 Sol)