Repository navigation
[pywin32] Type pscon property keys as PyPROPERTYKEY - #16656
Merged
Merged
Conversation
pywin32 represents a PROPERTYKEY as an `(IID, pid)` tuple, so make `PyPROPERTYKEY` an alias for `tuple[PyIID, int]` and use it for the 567 `PKEY_*` constants in `win32comext.propsys.pscon`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This comment has been minimized.
This comment has been minimized.
Avasam
reviewed
Oct 30, 2026
Avasam
left a comment
Avasam
left a comment
Collaborator
There was a problem hiding this comment.
Thanks!
All the *con.py modules in pywin32 are generated from Windows constants. Since you're modifying most of the module anyway, would you mind making these all as : Final (with the actual literal value whenever the linter doesn't whine)? We already do so in storagecon.pyi, win32con.pyi and isapicon.pyi if you want to see what I mean.
Use literal values for the integer constants and `Final[PyPROPERTYKEY]` for the property keys, as in `storagecon.pyi` and `isapicon.pyi`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Done — integer constants are now |
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pywin32 converts a
PROPERTYKEYto and from an(IID, pid)tuple (source), and everyPKEY_*constant inpsconis such a tuple (source). This makesPyPROPERTYKEYan alias fortuple[PyIID, int]and uses it for the 567PKEY_*constants (plusintforGUIDSTRING_MAX/PKEYSTR_MAX), so the constants can be passed topropsysfunctions that take aPyPROPERTYKEY.🤖 Generated with Claude Code