Repository navigation
tag-helpers: make enum and boolean request options non-nullable - #126
Merged
Merged
Conversation
Razor resolves a bare member name only for a non-nullable enum and allows an attribute without a value only for a non-nullable bool, so hx-request-cache="NoCache" failed with CS0103 and hx-request-validate without a value failed with RZ2008. Change Credentials, NoHeaders, Cache, Redirect, and Validate to non-nullable properties over the existing nullable storage. Razor calls a setter only for an attribute present in the markup, so an omitted attribute still leaves the option out of the JSON, while an explicit SameOrigin, Default, Follow, or false is still rendered. These attributes no longer accept a nullable value, such as @(condition ? HtmxRequestCache.NoCache : null), or a qualified name without @, such as HtmxRequestCache.NoCache. @HtmxRequestCache.NoCache keeps working.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Razor resolves a bare member name only for a non-nullable enum and allows an attribute without a value only for a non-nullable
bool,so
hx-request-cache="NoCache"failed withCS0103andhx-request-validatewithout a value failed withRZ2008.Change
Credentials,NoHeaders,Cache,Redirect, andValidateto non-nullable properties over the existing nullable storage.Razor calls a setter only for an attribute present in the markup, so an omitted attribute still leaves the option out of the JSON,
while an explicit
SameOrigin,Default,Follow, orfalseis still rendered.These attributes no longer accept a nullable value, such as
@(condition ? HtmxRequestCache.NoCache : null),or a qualified name without
@, such asHtmxRequestCache.NoCache.@HtmxRequestCache.NoCachekeeps working.