Skip to content

fix(ci): resolve Guice inject WARNING, correct OSSRH URLs, modernize GH Actions - #367

Open
maheshshinde9100 wants to merge 3 commits into
razorpay:masterfrom
maheshshinde9100:fix-latest-pr-bug
Open

maheshshinde9100 wants to merge 3 commits into
razorpay:masterfrom
maheshshinde9100:fix-latest-pr-bug

Conversation

@maheshshinde9100

Copy link
Copy Markdown

This PR fixes the Jul 29 publish job failure (v1.4.10 release #362) on two
fronts:

  1. Maven-side (pom.xml):

    • Bumps nexus-staging-maven-plugin 1.6.9 -> 1.7.0, eliminating the
      noisy Guice/MissingImplementation: ObjectMapper annotated with TypeArguments$Implicit WARNING on every mvn invocation.
    • Fixes both distributionManagement OSSRH URLs: snapshot repo now
      points to /snapshots/ (was wrongly /releases/) and the release
      repo now uses /service/local/staging/deploy/maven2/ so nexus-staging
      owns the staging-upload workflow (was bypassing staging).
    • Modernizes maven-gpg-plugin, maven-source-plugin, maven-javadoc-plugin
      for GPG 2.3+ and modern runner compatibility.
  2. GitHub Actions-side (.github/workflows/ci.yml):

    • Bumps actions/checkout (v2 -> v4) and actions/setup-java
      (v2 -> v4, distribution=temurin since adopt was retired) in both
      the test and publish jobs, removing the "Node.js 20 is deprecated"
      runner annotation. Bumps codecov/codecov-action v3 -> v4 (v3 sunset).

Also included: a separate, reviewable feature commit improving
parseResponse error handling and adding RazorpayException tests.

Verified locally: mvn validate clean (no Guice warnings),
mvn test passes 181/181, effective-pom resolves correct OSSRH URLs.

Note: the publish job's remaining 402 Payment Required from OSSRH is an
out-of-band Sonatype credentials/group-promotion issue — no source-code
change can affect it.

Comment thread .github/workflows/ci.yml Resolved
Comment thread .github/workflows/ci.yml Resolved
Comment thread .github/workflows/ci.yml Resolved
Comment thread .github/workflows/ci.yml Resolved
Comment thread .github/workflows/ci.yml Resolved
 to throw a clear RazorpayException if an entity class cannot be found, rather than failing with a NullPointerException
- Resolve response parsing errors in shaded/re-packaged environments (razorpay#333)
- Update Mockito and Jacoco for modern JDK compatibility
- Fix deprecated Mockito matchers in BaseTest
…A actions

- Bump nexus-staging-maven-plugin 1.6.9 -> 1.7.0 to eliminate the
  Guice/MissingImplementation WARNING (ObjectMapper annotated with
  TypeArguments) during Maven project scanning.
- Correct distributionManagement OSSRH URLs:
  - snapshot: /content/repositories/releases/ -> .../snapshots/
  - release:  /service/local/repositories/releases/content/ ->
              /service/local/staging/deploy/maven2/
  so nexus-staging owns the staging upload (and snapshots go to the
  snapshots repository).
- Bump plugins: maven-gpg-plugin 1.6 -> 3.2.7, maven-source-plugin
  3.0.1 -> 3.3.1, maven-javadoc-plugin 3.0.1 -> 3.8.0 for modern
  runner and GPG 2.3+ compatibility.
- Update .github/workflows/ci.yml: actions/checkout v2 -> v4,
  actions/setup-java v2 -> v4 with distribution=temurin (adopt was
  retired in 2021), codecov/codecov-action v3 -> v4. Eliminates the
  'Node.js 20 is deprecated' GitHub Actions annotation.
@maheshshinde9100

Copy link
Copy Markdown
Author

Hi maintainers, I’ve completed the CI fixes in this PR and verified the changes locally with mvn test (181/181 tests passing).
Could someone with write access please review this PR when convenient?
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant