Skip to content

Delete orphan RCTBridgeProxy shims (#59444) #59444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
christophpurrer wants to merge 1 commit into
base: main
Choose a base branch
from
+0 −65
Open

Delete orphan RCTBridgeProxy shims (#59444) #59444

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 0 additions & 65 deletions packages/react-native/React/Base/RCTBridgeProxy.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,40 +262,11 @@ - (RCTBridge *)batchedBridge
return (RCTBridge *)self;
}

- (void)setBatchedBridge
{
[self logError:@"This method is not supported. No-oping." cmd:_cmd];
}

- (RCTBridgeModuleListProvider)moduleProvider
{
[self logWarning:@"This method is not supported. Returning empty block" cmd:_cmd];
return ^{
return @[];
};
}

- (RCTModuleRegistry *)moduleRegistry
{
return _moduleRegistry;
}

/**
* RCTBridge (RCTCxxBridge)
*/

- (RCTBridge *)parentBridge
{
[self logWarning:@"This method is not supported. Returning bridge proxy." cmd:_cmd];
return (RCTBridge *)self;
}

- (BOOL)moduleSetupComplete
{
[self logWarning:@"This method is not supported. Returning YES." cmd:_cmd];
return YES;
}

- (void)registerAdditionalModuleClasses:(NSArray<Class> *)newModules
{
[self
Expand All @@ -304,37 +275,6 @@ - (void)registerAdditionalModuleClasses:(NSArray<Class> *)newModules
cmd:_cmd];
}

- (void)updateModuleWithInstance:(id<RCTBridgeModule>)instance
{
[self logError:@"This method is not supported. Nooping." cmd:_cmd];
}

- (void)startProfiling
{
[self logWarning:@"This method is not supported. Nooping." cmd:_cmd];
}

- (void)stopProfiling:(void (^)(NSData *))callback
{
[self logWarning:@"This method is not supported. Nooping." cmd:_cmd];
}

- (id)callNativeModule:(NSUInteger)moduleID method:(NSUInteger)methodID params:(NSArray *)params
{
[self logError:@"This method is not supported. Nooping and returning nil." cmd:_cmd];
return nil;
}

- (void)logMessage:(NSString *)message level:(NSString *)level
{
[self logWarning:@"This method is not supported. Nooping." cmd:_cmd];
}

- (void)_immediatelyCallTimer:(NSNumber *)timer
{
[self logWarning:@"This method is not supported. Nooping." cmd:_cmd];
}

/**
* RCTBridge (RCTUIManager)
*/
Expand All @@ -343,11 +283,6 @@ - (RCTUIManager *)uiManager
return (RCTUIManager *)_uiManagerProxy;
}

- (RCTBridgeProxy *)object
{
return self;
}

/**
* NSProxy setup
*/
Expand Down
Loading