Skip to content

Throw a JS error when a sync Java TurboModule method returns a non-native map or array #59697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tomekzaw wants to merge 2 commits into
base: main
Choose a base branch
from
+4 −4
Open

Throw a JS error when a sync Java TurboModule method returns a non-native map or array #59697

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d72c58e
Throw a JS error when a Java TurboModule sync method returns a non-na…
tomekzaw Oct 30, 2026
1cbf1b1
Type-check sync map and array results with dynamic_ref_cast
tomekzaw Oct 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...tive/ReactCommon/react/nativemodule/core/platform/android/ReactCommon/JavaTurboModule.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -892,8 +892,8 @@ jsi::Value JavaTurboModule::invokeJavaMethod(

jsi::Value returnValue = jsi::Value::null();
if (returnObject != nullptr) {
auto jResult = jni::adopt_local(returnObject);
auto result = jni::static_ref_cast<NativeMap::jhybridobject>(jResult);
auto result = jni::dynamic_ref_cast<NativeMap::jhybridobject>(
jni::adopt_local(returnObject));
returnValue =
jsi::valueFromDynamic(runtime, result->cthis()->consume());
}
Expand All @@ -912,8 +912,8 @@ jsi::Value JavaTurboModule::invokeJavaMethod(

jsi::Value returnValue = jsi::Value::null();
if (returnObject != nullptr) {
auto jResult = jni::adopt_local(returnObject);
auto result = jni::static_ref_cast<NativeArray::jhybridobject>(jResult);
auto result = jni::dynamic_ref_cast<NativeArray::jhybridobject>(
jni::adopt_local(returnObject));
returnValue =
jsi::valueFromDynamic(runtime, result->cthis()->consume());
}
Expand Down
Loading