Skip to content

Keep ActivityResultContract class names in R8 builds #59700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
tomekzaw wants to merge 2 commits into
base: main
Choose a base branch
from
+8 −1
Draft

Keep ActivityResultContract class names in R8 builds #59700

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
caf6bd5
Keep ActivityResultContract class names in R8 builds
tomekzaw Oct 30, 2026
2bf04cb
Format the activity result README
tomekzaw Oct 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/react-native/ReactAndroid/proguard-rules.pro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,3 +73,7 @@
-keep public class com.facebook.imageutils.** {
public *;
}

# Activity result launcher keys include the contract's class name. Keep those names so that R8
# doesn't merge different contracts into one class or rename them between builds.
-keepnames class * extends androidx.activity.result.contract.ActivityResultContract
5 changes: 4 additions & 1 deletion ...ReactAndroid/src/main/java/com/facebook/react/activityresult/__docs__/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,10 @@ The same stability concern applies to minification. If the app minifies class
names (R8/ProGuard), the obfuscated name of the owner class is not guaranteed to
be the same from one build to the next, so a result delivered after an app
update can be dropped. Keep the owner class's name (for example with
`-keepnames`) if results must survive across builds.
`-keepnames`) if results must survive across builds. React Native's consumer R8
rules already keep the names of `ActivityResultContract` subclasses, so R8
doesn't merge different contracts into one class, which would give them the same
key.

Registering the same contract class twice from one owner throws
`IllegalStateException`. In that case use the overload that takes a key:
Expand Down
Loading