Skip to content

Name the Hermes source archive after the Hermes version #59715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fairysword wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −1
Open

Name the Hermes source archive after the Hermes version #59715

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/react-native/ReactAndroid/hermes-engine/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,11 @@ val prefabHeadersDir = File("$buildDir/prefab-headers")
// CMake reads the backslashes of a Windows path as escape sequences, so we pass forward slashes.
val jsiDir = File(reactNativeRootDir, "ReactCommon/jsi")

val downloadHermesDest = File(downloadsDir, "hermes.tar.gz")
// Naming the tarball after the Hermes version lets `downloadsDir` hold more than one Hermes
// version, like it already does for the other third-party sources. Release tags are
// `hermes-v<version>`, so that prefix is stripped to keep the name at `hermes-<version>.tar.gz`.
val hermesTarballName = "hermes-${hermesVersionProvider.get().removePrefix("hermes-v")}.tar.gz"
val downloadHermesDest = File(downloadsDir, hermesTarballName)
val downloadHermes by
tasks.registering(Download::class) {
src(
Expand Down
Loading