Repository navigation
Cover decimal and negative transformOrigin strings in RNTester (#59726) - #59726
Open
Abbondanzo wants to merge 1 commit into
Open
Abbondanzo wants to merge 1 commit into
Abbondanzo wants to merge 1 commit into
Conversation
|
@Abbondanzo has exported this pull request. If you are a Meta employee, you can view the originating Diff in D128838946. |
meta-cla
Bot
added
the
CLA Signed
…#59726) Summary: The string form of `transformOrigin` used to tokenize with `\d+(?:%|px)`, which corrupted decimals and negatives: `'52.9% 88.2%'` parsed as `['9%', '2%', 0]`, `'-12.5px -7.5px'` as `[5, 5, 0]`, and `'left -20.5%'` threw in development. The parser now handles them, but RNTester's only `transformOrigin` example uses `'top left'`, so nothing renders or screenshots these values. This adds a "Transform origin with decimal and negative values" example. Each case draws a pink box with a string origin over a dashed outline with the equivalent array origin, both rotated 45 degrees, so any parsing difference separates the two shapes. The Transform visual test now captures it, with the same anti-aliasing tolerance as the other rotated captures. Changelog: [Internal] Differential Revision: D128838946
meta-codesync
Bot
changed the title
Abbondanzo
force-pushed
the
export-D128838946
branch
from
November 1, 2026 00:04
6162ec8 to
9e5d49a
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The string form of
transformOriginused to tokenize with\d+(?:%|px), which corrupted decimals and negatives:'52.9% 88.2%'parsed as['9%', '2%', 0],'-12.5px -7.5px'as[5, 5, 0], and'left -20.5%'threw in development. The parser now handles them, but RNTester's onlytransformOriginexample uses'top left', so nothing renders or screenshots these values.This adds a "Transform origin with decimal and negative values" example. Each case draws a pink box with a string origin over a dashed outline with the equivalent array origin, both rotated 45 degrees, so any parsing difference separates the two shapes. The Transform visual test now captures it, with the same anti-aliasing tolerance as the other rotated captures.
Changelog: [Internal]
Differential Revision: D128838946