Skip to content

fix: upgrade V8 and harden executor security boundaries - #2139

Draft
NathanFlurry wants to merge 23 commits into
mainfrom
security/v8-upgrade
Draft

NathanFlurry wants to merge 23 commits into
mainfrom
security/v8-upgrade

Conversation

@NathanFlurry

@NathanFlurry NathanFlurry commented Nov 21, 2026 •

Copy link
Copy Markdown
Member
  • Upgrade V8 with checksum-pinned native archives, a publishable lockstep Rust binding, and matched Linux/macOS headers; preserve upstream sources and license notices.
  • Harden resource, callback, networking, filesystem and serialization boundaries; retain V8 defaults and disable Obscura for this release.
  • Fix retained-context input, detached-child RPC ownership, disposal exit delivery, bounded stdout writes, Unix listener cleanup, file-read cancellation and encoding allocation checks.
  • Repair downstream fixtures and supply pinned native HTTP/3 references so the complete curl and DuckDB suites run; assert real disposal exits and wait for terminal rendering without relaxing snapshots or deadlines.

Validation: preceding-head four-platform execution, benchmark, Rust/Clippy, isolation, crate rehearsal, Core PR, transport, hosted integration, expanded VM/backend Rust and C conformance pass. Both expanded-Core CI failures pass locally after correction. The complete local expanded Core replay finished with one separate child-failure timeout; its unchanged full file passes in isolation. That intermittent failure remains recorded, and fresh exact-head CI is required before merge/release. Complete local curl and DuckDB suites pass.

Existing hosted dependency maintenance exceptions remain recorded; this change does not claim a clean advisory graph.

@github-actions

github-actions Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

📟 Pip-Boy · 9c15cbc

📦 Packages

Skipped: this PR doesn't change any published package.

🧹 Rust dependencies · cargo deny + cargo shear

check new in this PR fixed existing on base
advisories ✅ 0 18 1
licenses ✅ 0 0 0
sources ✅ 0 0 0
bans ✅ 0 0 0
unused 🟡 5 0 70
new finding via
unused dependency 'diplomat-runtime' crates/v8/Cargo.toml
unused dependency 'temporal_rs' crates/v8/Cargo.toml
unused dependency 'timezone_provider' crates/v8/Cargo.toml
unused dependency 'zoneinfo64' crates/v8/Cargo.toml
unused dependency 'diplomat' crates/v8/Cargo.toml

🦀 Binaries · publish Dockerfiles, --release

Base: main@5ef148b, the newest main commit with native builds before the merge base. Size changes merged to main since then show up here too.

artifact npm @latest base this PR Δ vs base
🔴 agentos-native-sidecar darwin-arm64 120.9 MB 128.8 MB 161.3 MB +32.5 MB (+25.2%)
🔴 agentos-native-sidecar darwin-x64 128.0 MB 135.8 MB 168.3 MB +32.5 MB (+23.9%)
🔴 agentos-native-sidecar linux-arm64-gnu 141.9 MB 150.7 MB 184.1 MB +33.4 MB (+22.1%)
🔴 agentos-native-sidecar linux-x64-gnu 142.4 MB 151.5 MB 185.1 MB +33.6 MB (+22.2%)
`agentos-native-sidecar linux-arm64-gnu` · crates that changed most (from symbol sizes, approximate)
crate base this PR Δ
agentos_executor_v8_runtime 2.4 MB 11.1 MB +8.7 MB (+360.4%)
v8 16.9 MB 22.4 MB +5.5 MB (+32.6%)
icu_78 0 B 1.5 MB +1.5 MB (new)
icu_74 1.4 MB 0 B −1.4 MB (−100.0%)
[c/other] 12.7 MB 13.6 MB +957.7 KB (+7.4%)
std 1.9 MB 2.2 MB +250.2 KB (+12.6%)
temporal_rs 0 B 159.9 KB +159.9 KB (new)
simdutf 0 B 156.2 KB +156.2 KB (new)
__llvm_libc_cr 0 B 153.2 KB +153.2 KB (new)
absl 40.7 KB 165.0 KB +124.2 KB (+304.9%)
`agentos-native-sidecar linux-x64-gnu` · crates that changed most (from symbol sizes, approximate)
crate base this PR Δ
agentos_executor_v8_runtime 2.6 MB 11.2 MB +8.7 MB (+337.2%)
[c/other] 23.4 MB 15.0 MB −8.5 MB (−36.1%)
v8 17.4 MB 23.2 MB +5.9 MB (+33.8%)
icu_78 0 B 1.5 MB +1.5 MB (new)
icu_74 1.5 MB 0 B −1.5 MB (−100.0%)
simdutf 0 B 428.4 KB +428.4 KB (new)
std 2.1 MB 2.3 MB +209.7 KB (+9.8%)
__llvm_libc_cr 0 B 194.6 KB +194.6 KB (new)
temporal_rs 0 B 172.0 KB +172.0 KB (new)
absl 35.3 KB 156.9 KB +121.6 KB (+344.8%)

⏱ Timing

job wall time slowest step
changes 26s checkout · 23s
zizmor 12s checkout · 3s
hygiene 59s checkout · 22s
native · darwin-x64 4m19s Build with the publish Dockerfile · 4m01s
self-test 28s Run pnpm --filter pipboy test · 9s
native · linux-x64-gnu 4m45s Build with the publish Dockerfile · 4m27s
native · linux-arm64-gnu 10m05s Build with the publish Dockerfile · 9m33s
native · darwin-arm64 4m18s Build with the publish Dockerfile · 3m59s
⏭ footprint — skipped
execute · linux-arm64-gnu 20s Run pnpm install --frozen-lockfile --ignore-scripts --filter '@rivet-dev/agentos...' · 6s
execute · darwin-x64 1m11s Execute the release sidecar through its matching public client · 24s
execute · darwin-arm64 41s Run pnpm install --frozen-lockfile --ignore-scripts --filter '@rivet-dev/agentos...' · 18s
execute · linux-x64-gnu 20s Run pnpm install --frozen-lockfile --ignore-scripts --filter '@rivet-dev/agentos...' · 7s
report 25s Write the comment and run summary · 8s
🔭 Full CI trace for this commit

One OpenTelemetry trace of CI and Pip-Boy for 9c15cbc: every job and step, with the sizes above attached. Run after CI finishes.

pnpm install --frozen-lockfile --filter 'pipboy...'
pnpm --filter pipboy pipboy trace --sha 9c15cbc8dd63f357a9600c3123d8ada51679164c

Add --otlp <url> to send it to any OTLP/HTTP collector.

Agent instruction: From a rivet-dev/agentos checkout, run the commands above, then read the trace file the last command prints. List the slowest jobs and steps and explain where CI time went.

@NathanFlurry NathanFlurry added the aggregate-ci Run exhaustive aggregate CI, including both WASM backends label Nov 21, 2026 — with ChatGPT Codex Connector
@NathanFlurry NathanFlurry added the promote-reviewed-v8 Publish reviewed content-addressed V8 archives label Nov 22, 2026
@NathanFlurry
NathanFlurry changed the base branch from v8-artifacts/security-upgrade to main November 22, 2026 01:44
@NathanFlurry
NathanFlurry force-pushed the security/v8-upgrade branch 3 times, most recently from 65757d6 to 20038e1 Compare November 22, 2026 07:15

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aggregate-ci Run exhaustive aggregate CI, including both WASM backends promote-reviewed-v8 Publish reviewed content-addressed V8 archives

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant