Repository navigation
test(pi): remove the failed-commit test that a merge added twice - #406
Merged
Merged
Conversation
The squash merge of #403 added the test "a commit that fails during a run reopens the harness at once" a second time. The second copy shares the poisonRuns counter with the first, so it waits for a count that is already past, and fails.
This was referenced Nov 17, 2026
📟 Pip-Boy ·
|
| package (linux-x64-gnu) | @latest |
base | this PR | Δ vs base | packages |
|---|---|---|---|---|---|
@rivet-dev/pi |
392.6 MB | 392.6 MB | 392.6 MB | 0 | 220 (0) |
@rivet-dev/sandbox-adapter |
114.5 KB | 114.5 KB | 114.5 KB | 0 | 1 (0) |
@sandbox-agent/cli-shared |
27.2 KB | 27.2 KB | 27.2 KB | 0 | 1 (0) |
@sandbox-agent/persist-indexeddb |
12.4 KB | 12.4 KB | 12.4 KB | 0 | 1 (0) |
@sandbox-agent/persist-postgres |
12.3 KB | 12.3 KB | 12.3 KB | 0 | 1 (0) |
@sandbox-agent/persist-rivet |
12.2 KB | 12.2 KB | 12.2 KB | 0 | 1 (0) |
@sandbox-agent/persist-sqlite |
12.3 KB | 12.3 KB | 12.3 KB | 0 | 1 (0) |
@sandbox-agent/react |
41.6 MB | 41.9 MB | 41.9 MB | 0 | 15 (0) |
acp-http-client |
6.7 MB | 6.7 MB | 6.7 MB | 0 | 3 (0) |
sandbox-agent |
31.0 MB | 31.0 MB | 31.0 MB | 0 | 8 (0) |
🧹 Rust dependencies
Skipped: this PR doesn't change any Rust code or dependencies.
🦀 Binaries
Skipped: this PR doesn't change any Rust code.
⏱ Timing
| job | wall time | slowest step |
|---|---|---|
zizmor |
19s | checkout · 12s |
changes |
18s | checkout · 13s |
footprint |
2m11s | Run pnpm --dir sandbox-agent install --frozen-lockfile · 54s |
⏭ native · ${{ matrix.platform }} |
— | skipped |
⏭ hygiene |
— | skipped |
⏭ self-test |
— | skipped |
report |
38s | checkout · 17s |
🔭 Full CI trace for this commit
One OpenTelemetry trace of CI and Pip-Boy for 19229cf: every job and step, with the sizes above attached. Run after CI finishes.
pnpm install --frozen-lockfile --filter 'pipboy...'
pnpm --filter pipboy pipboy trace --sha 19229cfac561896cc4f5e9365f97f638ee57d209Add --otlp <url> to send it to any OTLP/HTTP collector.
Agent instruction: From a rivet-dev/agents checkout, run the commands above, then read the trace file the last command prints. List the slowest jobs and steps and explain where CI time went.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The squash merge of #403 added the test "a commit that fails during a run reopens the harness at once, and the run finishes with no call" to
packages/pi/tests/actor.test.tsa second time.Both copies count tool runs in the same module-level
poisonRuns. The second copy runs after the first set it to 2, so itspoisonRunsreaches 3, and its wait for 2 fails.This removes the second copy.
packages/pi/testsis then the same as the tested head of #403.This is part 3 of 6 in a stack: