Skip to content

test(pi): remove the failed-commit test that a merge added twice - #406

Merged
eersnington merged 1 commit into
mainfrom
fix/pi-duplicate-poison-test
Nov 17, 2026
Merged

eersnington merged 1 commit into
mainfrom
fix/pi-duplicate-poison-test

Conversation

@eersnington

@eersnington eersnington commented Nov 17, 2026 •

Copy link
Copy Markdown
Member

The squash merge of #403 added the test "a commit that fails during a run reopens the harness at once, and the run finishes with no call" to packages/pi/tests/actor.test.ts a second time.

Both copies count tool runs in the same module-level poisonRuns. The second copy runs after the first set it to 2, so its poisonRuns reaches 3, and its wait for 2 fails.

This removes the second copy. packages/pi/tests is then the same as the tested head of #403.


This is part 3 of 6 in a stack:

The squash merge of #403 added the test "a commit that fails during a run
reopens the harness at once" a second time. The second copy shares the
poisonRuns counter with the first, so it waits for a count that is already
past, and fails.
@github-actions

Copy link
Copy Markdown

📟 Pip-Boy · 19229cf

📦 Packages · fresh npm install resolve, no lockfile · this PR vs base

No notable install size, dependency, or entrypoint changes across 10 packages.

All 10 packages · linux-x64-gnu
package (linux-x64-gnu) @latest base this PR Δ vs base packages
@rivet-dev/pi 392.6 MB 392.6 MB 392.6 MB 0 220 (0)
@rivet-dev/sandbox-adapter 114.5 KB 114.5 KB 114.5 KB 0 1 (0)
@sandbox-agent/cli-shared 27.2 KB 27.2 KB 27.2 KB 0 1 (0)
@sandbox-agent/persist-indexeddb 12.4 KB 12.4 KB 12.4 KB 0 1 (0)
@sandbox-agent/persist-postgres 12.3 KB 12.3 KB 12.3 KB 0 1 (0)
@sandbox-agent/persist-rivet 12.2 KB 12.2 KB 12.2 KB 0 1 (0)
@sandbox-agent/persist-sqlite 12.3 KB 12.3 KB 12.3 KB 0 1 (0)
@sandbox-agent/react 41.6 MB 41.9 MB 41.9 MB 0 15 (0)
acp-http-client 6.7 MB 6.7 MB 6.7 MB 0 3 (0)
sandbox-agent 31.0 MB 31.0 MB 31.0 MB 0 8 (0)

🧹 Rust dependencies

Skipped: this PR doesn't change any Rust code or dependencies.

🦀 Binaries

Skipped: this PR doesn't change any Rust code.

⏱ Timing

job wall time slowest step
zizmor 19s checkout · 12s
changes 18s checkout · 13s
footprint 2m11s Run pnpm --dir sandbox-agent install --frozen-lockfile · 54s
⏭ native · ${{ matrix.platform }} — skipped
⏭ hygiene — skipped
⏭ self-test — skipped
report 38s checkout · 17s
🔭 Full CI trace for this commit

One OpenTelemetry trace of CI and Pip-Boy for 19229cf: every job and step, with the sizes above attached. Run after CI finishes.

pnpm install --frozen-lockfile --filter 'pipboy...'
pnpm --filter pipboy pipboy trace --sha 19229cfac561896cc4f5e9365f97f638ee57d209

Add --otlp <url> to send it to any OTLP/HTTP collector.

Agent instruction: From a rivet-dev/agents checkout, run the commands above, then read the trace file the last command prints. List the slowest jobs and steps and explain where CI time went.

@eersnington
eersnington merged commit d119416 into main Nov 17, 2026
10 checks passed
@eersnington
eersnington deleted the fix/pi-duplicate-poison-test branch November 17, 2026 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant