Skip to content

[civetweb] download and patch tarball with 588860e3 commit - #23948

Draft
linev wants to merge 3 commits into
root-project:masterfrom
linev:civetweb_download
Draft

linev wants to merge 3 commits into
root-project:masterfrom
linev:civetweb_download

Conversation

@linev

@linev linev commented Nov 2, 2026 •

Copy link
Copy Markdown
Member

git clone from repository is very "expensive" in terms of time and produced traffic.

In fact only very small core part of the civetweb code is used in the ROOT.

Therefore just create minimal tarball ourself, download it and apply same patches as for git repository

Trying also fix cmake warning when provide list of libs as argument - trying to use LIST_SEPARATOR "|" argument

git clone from repository is very "expensive" in terms of time
and traffic produced. In fact only very small core part of the civetweb
code is used in the ROOT.

Therefore just create minimal tarball ourself and download it
@linev linev self-assigned this Nov 2, 2026
@linev
linev requested a review from bellenot as a code owner November 2, 2026 12:52
@linev
linev marked this pull request as draft November 2, 2026 12:52
@github-actions

github-actions Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Test Results

    2 files      2 suites   4h 4m 14s ⏱️
3 826 tests 3 826 ✅ 0 💤 0 ❌
6 467 runs  6 467 ✅ 0 💤 0 ❌

Results for commit d7d7d18.

♻️ This comment has been updated with latest results.

Put in civetweb-588860e3.tar.gz code  from 588860e3 commit and apply our patches to it. Then build with same commands as with git checkout
@linev linev changed the title [civetweb] download patched version [civetweb] download and patch tarball with 588860e3 commit Nov 3, 2026
# URL_HASH SHA256=${ROOT_CIVETWEB_HASH}

# ------- here is extract of 588860e3 commit ------
URL https://jsroot.gsi.de/civetweb-588860e3.tar.gz

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
URL https://jsroot.gsi.de/civetweb-588860e3.tar.gz
URL https://root.cern/download/civetweb-588860e3.tar.gz
https://jsroot.gsi.de/civetweb-588860e3.tar.gz

With #23963, I'm trying to ensure that every tarball has two mirrors: one at CERN (usually LCG), tried first, and then an "external" (usually GitHub).

To preserve this also for civetweb, maybe we can put the same civetweb-588860e3.tar.gz also on root.cern? If the tarball is final, then @dpiparo could upload it there

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guitargeek
Lets wait until all builds are green.
I also see some warnings during build (on my Linux I normally using external civetweb) and want to fix them

@linev linev added the clean build Ask CI to do non-incremental build on PR label Nov 3, 2026
@linev

linev commented Nov 3, 2026

Copy link
Copy Markdown
Member Author

Need to restart for clean build

@linev linev closed this Nov 3, 2026
@linev linev reopened this Nov 3, 2026
@linev
linev force-pushed the civetweb_download branch from d7d7d18 to afff951 Compare November 3, 2026 16:27

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clean build Ask CI to do non-incremental build on PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants