Repository navigation
[rfile][python] add support for __getitem__ and __contains__ - #23965
Open
silverweed wants to merge 2 commits into
Open
silverweed wants to merge 2 commits into
silverweed wants to merge 2 commits into
Conversation
silverweed
requested review from
guitargeek,
jblomer,
pcanal,
siliataider and
vepadulano
as code owners
November 3, 2026 10:27
silverweed
force-pushed
the
rfile_getdict
branch
from
November 3, 2026 10:29
2d501d9 to
f610bbd
Compare
jblomer
approved these changes
Nov 3, 2026
dpiparo
approved these changes
Nov 3, 2026
dpiparo
left a comment
Member
There was a problem hiding this comment.
Thanks for this useful pythonisations!
vepadulano
approved these changes
Nov 3, 2026
vepadulano
left a comment
Member
There was a problem hiding this comment.
Thank you this is really useful!
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
adds support for the dictionary syntax in RFile:
as well as the
inoperator:NOTE: to mirror python's default behavior with the dictionary syntax,
file['obj']will raise aKeyErrorifobjis not infile. This is different fromfile.Get('obj'), which will instead returnNone.Checklist: