Repository navigation
Conversation
guitargeek
requested changes
Nov 3, 2026
| endif() | ||
| add_custom_command( | ||
| COMMAND ${ROOT_genreflex_CMD} | ||
| COMMAND ${CMAKE_COMMAND} -E env "ROOTIGNOREPREFIX=1" ${ROOT_genreflex_CMD} |
Contributor
There was a problem hiding this comment.
The ROOTIGNOREPREFIX=1 has to be set only when genreflex is running in the build tree. So it has to be inserted a few lines above only in the CMAKE_PROJECT_NAME STREQUAL ROOT branch:
if(CMAKE_PROJECT_NAME STREQUAL ROOT)
set(ROOT_genreflex_CMD ${CMAKE_COMMAND} -E env "ROOTIGNOREPREFIX=1" $<TARGET_FILE:genreflex>)
elseif(TARGET ROOT::genreflex)Would that work instead? Otherwise, we risk breaking use of the REFLEX_GENERATE_DICTIONARY macro by downstream projects.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
Changes or fixes:
Ignore prefix when running binaries in the build tree during build.
Checklist: