Repository navigation
Update rustls, rustls-webpki and webpki-root-certs past their advisories - #87
Merged
Merged
Conversation
`cargo audit` fails on main, and so on every open PR, over six advisories published in October: - rustls 0.23.45: RUSTSEC-2026-0346, 0347, 0348 and 0349, fixed in 0.23.46 - rustls-webpki 0.103.15: RUSTSEC-2026-0382, fixed in 0.103.16 - webpki-root-certs 1.0.9: RUSTSEC-2026-0383, fixed in 1.0.10 `cargo update -p` moves each to its latest compatible release. All three come in only through jsonschema, a dev-dependency, so the pks binary never contained them. Re-resolving rustls also moves tempfile's getrandom from 0.4.3 to 0.3.4, both of which tempfile's `>=0.3, <0.5` allows; Dependabot's lock in #86 makes the same change. tempfile is also test-only. `cargo audit` still reports tokio 1.53.2 as unsound (RUSTSEC-2026-0386), but as a warning, which doesn't fail the job.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cargo auditfails on main, and so on #84, #85 and #86, over six advisories published in October:This is
cargo update -pfor the three crates, with no Cargo.toml change. All three come in only through jsonschema, a dev-dependency, so the pks binary never contained them.Re-resolving rustls also moves tempfile's getrandom from 0.4.3 to 0.3.4, both within tempfile's
>=0.3, <0.5. Dependabot's lock in #86 makes the same change, and tempfile is test-only too.cargo auditstill lists tokio 1.53.2 as unsound (RUSTSEC-2026-0386), as a warning that doesn't fail the job.Once this merges, #86 has nothing left to do, and #84 and #85 should pass the audit after Dependabot rebases them. #85 still fails to compile with ruby-prism's new release, which is separate from this.
Tested locally:
cargo auditexits 0, andcargo test --lockedpasses.