Repository navigation
fix(page): wake navigation when a loading frame detaches - #672
Open
oleksii-leonov wants to merge 1 commit into
Open
oleksii-leonov wants to merge 1 commit into
oleksii-leonov wants to merge 1 commit into
Conversation
Chromium's out-of-process PDF viewer (PdfOopif) can finish the main PDF document before swapping out its still-loading iframe, without sending frameStoppedLoading for that child. Removing the frame without signaling idle leaves the click waiting until the navigation timeout. PdfOopif became the default on Windows/macOS/Linux in Chromium 145: https://chromium-review.googlesource.com/c/chromium/src/+/7239572 With unfixed Ferrum, Linux Chrome-for-Testing 145.0.7570.0 passes and 145.0.7571.0 times out. The first Linux stable 145 release, 145.0.7632.45, also times out. Each boundary case was checked three times. This is feature-dependent, not limited to a browser version: enabling PdfOopif reproduces the same failure on Chrome 139 and 144; disabling it makes Chrome 145 pass. Feature controls preserve Ferrum's other defaults. The fix passes on Chrome 139 with PdfOopif enabled and both affected 145 builds above, three times each. Recheck the existing idle predicate after removing a detached child. Keep main-frame detachment unchanged and continue waiting for loading frames or a main execution context that has been cleared. Add an inline-PDF POST regression using the existing PDF fixture, plus deterministic CDP regressions for swap/removal and premature completion. The PDF and both child-detachment cases fail before the fix. Validation on Chromium 155.0.8059.39: 683 examples, zero failures, four environment-dependent skips. Another 104 examples pass on Chrome 139. Full RuboCop and changed-line/branch coverage pass. RBS validation reports the same missing dependency types on unchanged upstream d7a9902; no method signatures or dependencies change here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chromium's out-of-process PDF viewer (PdfOopif) can finish the main PDF document before swapping out its still-loading iframe, without sending frameStoppedLoading for that child. Removing the frame without signaling idle leaves the click waiting until the navigation timeout.
PdfOopif became the default on Windows/macOS/Linux in Chromium 145: https://chromium-review.googlesource.com/c/chromium/src/+/7239572
With unfixed Ferrum, Linux Chrome-for-Testing 145.0.7570.0 passes and 145.0.7571.0 times out. The first Linux stable 145 release, 145.0.7632.45, also times out. Each boundary case was checked three times.
This is feature-dependent, not limited to a browser version: enabling PdfOopif reproduces the same failure on Chrome 139 and 144; disabling it makes Chrome 145 pass. Feature controls preserve Ferrum's other defaults. The fix passes on Chrome 139 with PdfOopif enabled and both affected 145 builds above, three times each.
Recheck the existing idle predicate after removing a detached child. Keep main-frame detachment unchanged and continue waiting for loading frames or a main execution context that has been cleared.
Add an inline-PDF POST regression using the existing PDF fixture, plus deterministic CDP regressions for swap/removal and premature completion. The PDF and both child-detachment cases fail before the fix.
Validation on Chromium 155.0.8059.39: 683 examples, zero failures, four environment-dependent skips. Another 104 examples pass on Chrome 139. Full RuboCop and changed-line/branch coverage pass. RBS validation reports the same missing dependency types on unchanged upstream d7a9902; no method signatures or dependencies change here.