Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #59, reported by @justinmerrell.
With
--rp_debuggerenabled, valid scalar/list handler results and error-only results raiseTypeErrororKeyErrorbeforesend_result. The existing condition checks the dictionary result envelope, then indexes its output as a dictionary.Check the output instead. Dictionary outputs retain debugger metadata; other results keep their existing format and reach delivery. This also covers aggregated generator output.
pytest tests/test_serverless/test_modules/test_job_debugger.py -q -o addopts=fails 9 cases on main (with one dictionary control passing) and passes all 10 here. Tests execute realhandle_job,run_joband generator processing; only result transport and debugger probes are mocked.Full unit suite: 2743 passed, 6 subtests passed, 94.28% coverage with the 90% requirement retained. Independent review and changed-code/new-test Black checks pass.
Full-suite command and scope
python -m pytest --cov-config=pyproject.toml --cov=runpod --cov-report=term-missing --cov-report=xml -qon Python 3.12.8. The explicit config uses the checked-in coverage omissions; pytest.ini otherwise references an absent.coveragerc. No config was changed. Existing unrelated formatting inrp_job.pyis untouched. Live cloud E2E was not run.