Repository navigation
Skip saltext-zabbix editable-install tests on Python 3.10 - #341
Merged
Merged
Conversation
test_install_editable_package and test_install_editable_package_in_extras clone HEAD of https://github.com/salt-extensions/saltext-zabbix and run `pip install -e saltext-zabbix`. saltext-zabbix bumped its python_requires to >=3.11, so on Python 3.10 pip refuses the install and the tests fail with ``assert p.returncode == 0``. Mark both tests skipif(sys.version_info < (3, 11)). They cover the editable-install path, not anything zabbix-specific, and the salt-extensions ecosystem is dropping 3.10 broadly, so pinning a legacy tag would just defer this. Linux 3.11+ coverage is preserved.
The previous commit used ``@pytest.mark.skipif(sys.version_info < (3, 11))``, which evaluates against the Python running pytest -- the host runner Python (3.11+), not the relenv-built Python under test. So on the ``Verify Linux (3.10, ...)`` jobs the marker never fired and the tests still ran against a 3.10 relenv build, hitting the same ``pip install -e saltext-zabbix`` failure. Move the check inside the test body and gate on the ``minor_version`` fixture (which yields the build Python's ``MAJOR.MINOR``). Matches the in-body ``pytest.skip(reason=...)`` pattern already used elsewhere in this file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Observed in https://github.com/saltstack/relenv/actions/runs/41045572338 (`Verify Linux (3.10, x86_64)` and `Verify Linux (3.10, aarch64)`), both blocking PR #338.
Test plan