Repository navigation
feat(website): build a site's server image from source or a registry, and verify its state at /go (FD-4683) #392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
williamloo-scale
wants to merge
7
commits into
wloo/web-apps-deploy
Choose a base branch
from
wloo/web-apps-verifier
base: wloo/web-apps-deploy
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+520
−74
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
c807a8e
feat(website): build a site's server image from source or a registry,…
williamloo-scale d8d569c
Merge wloo/web-apps-deploy into wloo/web-apps-verifier
williamloo-scale b180cfe
test(website): expect the server-image error from a website put with …
williamloo-scale ddce3f3
Merge wloo/web-apps-deploy into wloo/web-apps-verifier
williamloo-scale 2fdb925
Merge wloo/web-apps-deploy into wloo/web-apps-verifier
williamloo-scale d92d937
Merge wloo/web-apps-deploy into wloo/web-apps-verifier
williamloo-scale 281b0c5
Merge wloo/web-apps-deploy into wloo/web-apps-verifier
williamloo-scale File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--health-pathis checked only after the image has been built and saved. For example,--health-path healthzfinishes a GitHub build beforeWebsiteEnv.putrejects the missing slash. Local builds and registry registration also save an image artifact before failing. This is non-blocking, but wastes work and leaves saved artifacts from failed commands. Checkhealth_path_problembefore starting any build or registry write.Prompt To Fix With AI