Repository navigation
feat(temporal): add workload identity authentication - #562
Merged
Merged
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
asyncio.CancelledError is not an Exception, so a cancelled get_token or Client.connect skipped credential.close() and left the credential's HTTP resources open. Catch it with Exception, close the credential, and re-raise. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mzohaib-scale
approved these changes
Nov 2, 2026
danielmillerp
approved these changes
Nov 2, 2026
MeeSo-Scale
approved these changes
Nov 2, 2026
ntamas92
approved these changes
Nov 2, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This PR has the same commits as #560, on a branch in this repository instead of a fork.
Add renewable Azure Workload Identity authentication to the ADK Temporal client.
How
TEMPORAL_AUTH_SCOPEopts in. Tokens are acquired and refreshed through Azure Identity. Initial or expired credentials fail closed, while a transient refresh failure keeps the current valid token and retries once after the retry delay. Authenticated in-cluster connections settls=Falseso Istio remains the transport-security layer. Explicit TLS configuration and the scope-unset path are unchanged. The change is limited to hand-written code undersrc/agentex/lib/.Verification
tests/lib/test_temporal_auth.pypasses 10/10. Removing the plaintext TLS guard, reverting the single-retry delay, or dropping theCancelledErrorcleanup makes the matching test fail.Cluster impact
None until an agent is released with this ADK version and deployed with
TEMPORAL_AUTH_SCOPE.🤖 Generated with Claude Code
The changes since the previous review appear safe to merge.Summary
Adds opt-in Azure Workload Identity authentication and token renewal for Temporal clients.
Reviews (2) · Last reviewed commit: "fix(temporal): close credential when sta..." · Reviewed by Greptile