Repository navigation
feat(temporal): add workload identity authentication - #475
Closed
mzohaib-scale wants to merge 2 commits into
Closed
mzohaib-scale wants to merge 2 commits into
mzohaib-scale wants to merge 2 commits into
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add renewable Azure Workload Identity authentication to Agentex Temporal clients.
Why
Lets Agentex Temporal clients authenticate with Azure Workload Identity.
How
TEMPORAL_AUTH_SCOPEopts in. Tokens are acquired and refreshed through Azure Identity. Initial or expired credentials fail closed, while a transient refresh failure retains the current valid token. Authenticated in-cluster connections settls=Falseso Istio remains the transport-security layer. Explicit TLS configuration and the scope-unset path are unchanged.Verification
The focused suite passes 8/8. Ruff and diff checks pass. Removing the plaintext TLS guard makes its regression test fail.
Cluster impact
None until an Agentex release is deployed with
TEMPORAL_AUTH_SCOPE.

Confidence Score: 5/5
The PR appears safe to merge; the previous retry-timing issue is fixed and no new actionable issues were found.Summary
Adds opt-in Azure Workload Identity authentication for Temporal clients.
Diagram
%%{init: {'theme': 'neutral'}}%% flowchart TD A[Connect to Temporal] --> B{Auth scope set?} B -->|No| C[Use existing connection options] B -->|Yes| D[Acquire Azure token] D -->|Failed or expired| E[Close credential and fail] D -->|Valid| F[Connect with token and start refresh] F --> G[Wait until refresh] G --> H{Refresh succeeds?} H -->|Yes| I[Replace token and calculate next wait] I --> G H -->|No| J[Keep current token and wait 30 seconds] J --> HReviews (2) · Last reviewed commit: "fix(temporal): correct token refresh ret..." · Reviewed by Greptile