Skip to content

feat(temporal): add workload identity authentication - #475

Closed
mzohaib-scale wants to merge 2 commits into
mainfrom
VULN-2040/temporal-authentication
Closed

mzohaib-scale wants to merge 2 commits into
mainfrom
VULN-2040/temporal-authentication

Conversation

@mzohaib-scale

@mzohaib-scale mzohaib-scale commented Oct 31, 2026 •

Copy link
Copy Markdown
Collaborator

What

Add renewable Azure Workload Identity authentication to Agentex Temporal clients.

Why

Lets Agentex Temporal clients authenticate with Azure Workload Identity.

How

TEMPORAL_AUTH_SCOPE opts in. Tokens are acquired and refreshed through Azure Identity. Initial or expired credentials fail closed, while a transient refresh failure retains the current valid token. Authenticated in-cluster connections set tls=False so Istio remains the transport-security layer. Explicit TLS configuration and the scope-unset path are unchanged.

Verification

The focused suite passes 8/8. Ruff and diff checks pass. Removing the plaintext TLS guard makes its regression test fail.

Cluster impact

None until an Agentex release is deployed with TEMPORAL_AUTH_SCOPE.

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge; the previous retry-timing issue is fixed and no new actionable issues were found.

Summary

Adds opt-in Azure Workload Identity authentication for Temporal clients.

  • Agentex Temporal clients can authenticate with renewable Azure tokens.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Connect to Temporal] --> B{Auth scope set?}
  B -->|No| C[Use existing connection options]
  B -->|Yes| D[Acquire Azure token]
  D -->|Failed or expired| E[Close credential and fail]
  D -->|Valid| F[Connect with token and start refresh]
  F --> G[Wait until refresh]
  G --> H{Refresh succeeds?}
  H -->|Yes| I[Replace token and calculate next wait]
  I --> G
  H -->|No| J[Keep current token and wait 30 seconds]
  J --> H
Loading

Reviews (2) · Last reviewed commit: "fix(temporal): correct token refresh ret..." · Reviewed by Greptile

@mzohaib-scale
mzohaib-scale requested a review from a team as a code owner October 31, 2026 20:39
@socket-security

socket-security Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedpypi/​azure-identity@​1.27.097100100100100

View full report

@declan-scale
declan-scale deleted the VULN-2040/temporal-authentication branch November 2, 2026 16:30
@scaleapi scaleapi deleted a comment from greptile-apps Bot Nov 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant