Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
... and 1 file with indirect coverage changes @@ Coverage Diff @@
## bugfix/CLDSRV-1021-copy-source-bucket-policy #6332 +/- ##
================================================================================
+ Coverage 85.31% 85.36% +0.04%
================================================================================
Files 207 207
Lines 13473 13480 +7
================================================================================
+ Hits 11495 11507 +12
+ Misses 1978 1973 -5
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
leif-scality
approved these changes
Oct 29, 2026
leif-scality
left a comment
leif-scality
left a comment
Contributor
There was a problem hiding this comment.
A Deny on s3:VersionId now blocks copying that version, in bucket and IAM policies, and a repeated versionId in the copy source is rejected. I found no regressions. The new functional test fails without the fix and passes with it, and the stack's functional tests pass 20/20 against Vault 7.89.0. The other-spelling bypass stays in CLDSRV-1038, as the description says.
tcarmet
force-pushed
the
bugfix/CLDSRV-1021-copy-source-version-id
branch
from
October 30, 2026 16:48
57d9720 to
5c5a75b
Compare
…sent - Use the copy source version ID as sent by the client, for both the bucket policy and the authorization request, instead of the internal version ID - Return InvalidArgument when the copy source versionId is repeated, so an array never reaches the bucket policy conditions
tcarmet
force-pushed
the
bugfix/CLDSRV-1021-copy-source-version-id
branch
from
October 30, 2026 22:58
5c5a75b to
7a9b5bc
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A policy condition on
s3:VersionIdwas compared with the copy source's internal version ID instead of the version ID the client sent. So a Deny on a specific version blocked a GetObject of that version but not a copy of it, in both bucket and identity policies. The copy source's version ID is now evaluated as sent, like for a direct GetObject. A repeatedversionIdin the copy source is rejected, so it never reaches policy evaluation as a list. Version IDs that decode to the same version under different spellings are still not normalized; that's tracked in CLDSRV-1038 and affects GetObject the same way.Stacked on #6324.