Skip to content

CLDSRV-1031: Report the health of every configured KMS - #6347

Open
dvasilas wants to merge 1 commit into
development/9.6from
improvement/CLDSRV-1031-report-health-of-every-kms
Open

dvasilas wants to merge 1 commit into
development/9.6from
improvement/CLDSRV-1031-report-health-of-every-kms

Conversation

@dvasilas

Copy link
Copy Markdown
Contributor

Context (S3C-11459): Allow a deployment to configure multiple KMSs.


The deep health check currently reports only the default KMS, keyed by its client type (kmip, aws, fileKms, …). The other configured KMSs are never checked.

This PR runs the existing KMS health check for every configured KMS and reports one entry per KMS, keyed by its providerName.

Example:

    "thales": { "code": 200, "message": "OK", "lastChecked": "2026-10-30T09:12:44.000Z" },
    "local": { "code": 200, "message": "OK" },
    "scality": { "code": 200, "message": "OK" }

KMS health stays informational: a failing KMS fails neither start-up nor readiness, even when every KMS fails. A KMS whose client has no health check reports OK without being contacted; today only the KMIP client has one.

The deep health check has one entry per configured KMS, keyed by its providerName, each with its own cache; KMS failures stay informational.
@bert-e

bert-e commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

Hello dvasilas,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval ⭐
/bypass_build_status Bypass the build and test status ⭐
/bypass_commit_size Bypass the check on the size of the changeset TBA ⭐
/bypass_incompatible_branch Bypass the check on the source branch prefix ⭐
/bypass_jira_check Bypass the Jira issue check ⭐
/bypass_peer_approval Bypass the pull request peers' approval ⭐
/bypass_leader_approval Bypass the pull request leaders' approval ⭐
/bypass_source_branch_lineage Bypass the cross-branch contamination check ⭐
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request.
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e

bert-e commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

Comment thread tests/functional/kmip/serverside_encryption.js Dismissed
Comment thread lib/kms/wrapper.js Dismissed
Comment thread lib/kms/wrapper.js Dismissed
Comment thread lib/kms/wrapper.js Dismissed
@codecov

codecov Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.68%. Comparing base (4811fc1) to head (45aed63).
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
lib/kms/wrapper.js 89.28% <100.00%> (+0.76%) ⬆️

... and 2 files with indirect coverage changes

@@                 Coverage Diff                 @@
##           development/9.6    #6347      +/-   ##
===================================================
- Coverage            90.71%   90.68%   -0.03%     
===================================================
  Files                  207      207              
  Lines                38843    38886      +43     
===================================================
+ Hits                 35235    35265      +30     
- Misses                3608     3621      +13     
Flag Coverage Δ
checksums-disabled-tests 46.10% <56.98%> (+0.06%) ⬆️
file-ft-tests 75.76% <56.98%> (+<0.01%) ⬆️
file-ft-tests-null-compat 76.22% <56.98%> (+0.02%) ⬆️
kmip-ft-tests 43.51% <84.94%> (+0.23%) ⬆️
mongo-v0-ft-tests 76.81% <56.98%> (+0.05%) ⬆️
mongo-v1-ft-tests 76.79% <56.98%> (-0.01%) ⬇️
multiple-backend 44.50% <56.98%> (+0.06%) ⬆️
s3c-ft-tests-v0 71.61% <56.98%> (+0.03%) ⬆️
s3c-ft-tests-v0-null-compat 71.66% <56.98%> (+0.03%) ⬆️
s3c-ft-tests-v1 71.57% <56.98%> (+0.03%) ⬆️
sur-tests 45.00% <56.98%> (+0.04%) ⬆️
sur-tests-inflights 48.39% <56.98%> (+0.03%) ⬆️
unit 80.20% <100.00%> (+0.02%) ⬆️
utapi-v2-tests 45.03% <56.98%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants