Repository navigation
Conversation
The deep health check has one entry per configured KMS, keyed by its providerName, each with its own cache; KMS failures stay informational.
Contributor
Hello dvasilas,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Contributor
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
... and 2 files with indirect coverage changes @@ Coverage Diff @@
## development/9.6 #6347 +/- ##
===================================================
- Coverage 90.71% 90.68% -0.03%
===================================================
Files 207 207
Lines 38843 38886 +43
===================================================
+ Hits 35235 35265 +30
- Misses 3608 3621 +13
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context (S3C-11459): Allow a deployment to configure multiple KMSs.
The deep health check currently reports only the default KMS, keyed by its client type (
kmip,aws,fileKms, …). The other configured KMSs are never checked.This PR runs the existing KMS health check for every configured KMS and reports one entry per KMS, keyed by its
providerName.Example:
KMS health stays informational: a failing KMS fails neither start-up nor readiness, even when every KMS fails. A KMS whose client has no health check reports OK without being contacted; today only the KMIP client has one.