Repository navigation
Fix lotsizing_lazy example: lock variables in conslock - #1252
Merged
Merged
Conversation
…nnot aggregate them away (#1228)
|
@Joao-Dionisio, do I have to check something? |
Member
Author
|
@abb-omidi you don't have to, of course, just if you have the time :) You can see here the changes I made, essentially adding variable locks. |
Member
Author
|
Later on we might want to run the examples before releases as well, this is something we've been neglecting. |
Joao-Dionisio
enabled auto-merge
November 5, 2026 15:16
Joao-Dionisio
disabled auto-merge
November 5, 2026 15:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #1228. @abb-omidi , do you mind taking a look?
The example's
conslockwas empty. The handler is included withneedscons=False, so SCIP relies on it to lock the variables it enforces. Without the locks, presolve aggregated the relaxedyvariables away (a weak dual reduction, soallowstrongdualreds=0didn't help), and the cuts added later cut off the optimum (75 instead of 57).Now
conslocklocksxandy, theallowstrongdualredsworkaround is gone, and a test runs the example and checks that both objectives are 57.