Repository navigation
build: use Ubuntu 24.04 go-rust-builder and coordinator-api - #1827
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Title check |  |
The title uses the required build type and identifies the Ubuntu 24.04 Go/Rust builder update. It also names the coordinator-api runtime change, but it does not mention the other Dockerfiles affected. |
| Description check | |
The description explains what the PR changes, why the changes are needed, and how they are implemented. It includes the required conventional commit, deployment versioning, and breaking change section… |
| Docstring Coverage | |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
Full details: Description check
-
Explanation
The description explains what the PR changes, why the changes are needed, and how they are implemented. It includes the required conventional commit, deployment versioning, and breaking change sections with appropriate selections.
Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files. (12 skipped: 12 unsupported.)
✨ Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1827 +/- ##
========================================
Coverage 30.71% 30.71%
========================================
Files 263 263
Lines 22827 22827
========================================
Hits 7011 7011
Misses 15127 15127
Partials 689 689
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Purpose or design rationale of this PR
Moves all Go service images to the new builder image
scrolltech/go-rust-builder:go-1.26.10-rust-nightly-2025-11-20-ubuntu-24.04(published from #1826's workflow).rust-toolchain.coordinator-apiruntime:ubuntu:20.04→ubuntu:24.04.libzkp.sonow links OpenSSL 3 from the 24.04 builder, solibssl3t64is installed explicitly. The existing--versionsmoke test loadslibzkp.so.rollup/proposer_tool.Dockerfile: builder and runtime moved to 24.04, plus a--versionsmoke test. build: bump versions (l2geth-v5.10.11, Go 1.26.10, Ubuntu 24.04) #1826 missed this file.Binaries built on the 24.04 builder need glibc 2.39, so every image using it now has a 24.04 runtime.
PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
Deployment tag versioning
Has
tagincommon/version.gobeen updated or have you addedbump-versionlabel to this PR?Breaking change label
Does this PR have the
breaking-changelabel?Summary by CodeRabbit